Fixes for yeoman generator - #56
Merged
Merged
Conversation
added 9 commits
June 30, 2014 10:10
Fix `ModelDefinition.getConfigData` to include model name in the generated data.
The list is maintained in the file `available-connectors.json` for now.
A list of types to offer when creating a new property.
Rename the property `humanized` to `name`. Add `ModelAccessControl.getBuiltinRoles`. Add the `cb` argument where missing.
Add a new `embedded` property `name` that overrides the serialized property name (`acls` instead of `accessControls`). Fix deserialization of embedded arrays: - use `id` from the data as an id property - this has to be fixed later. - fill `relatedModel[foreignKey]` with the model name to preserve entity relation
Move calls of `loader.emit` to the very last callback, to make sure the events are raised only once and only after all work has already been done.
Fix ModelAccessControl model to match the ACL definition expected by loopback.
Fill `relatedModel[foreignKey]` with the model name to preserve entity relation.
Member
There was a problem hiding this comment.
I'd like to change this in 2.0. "Access Control Lists" is misleading / incorrect.
Member
Author
There was a problem hiding this comment.
I quite like permissions, it was used by 2.0 workspace API.
Unless you have time to implement that change today, I am proposing to merge this PR and make the change later.
BTW to make the migration easy, LB 2.0 should support both old (acls) and the new property when reading config files. workspace should probably support the old name too at read-time
Member
|
LGTM |
This was referenced Jul 1, 2014
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch contains changes required by
yo loopbackand fixes for bugs discovered along the way.namein the json filelistAvailableConnectorsavailableTypes/to @ritch please review